Skip to content

[v18.x] Temporarily revert libuv

Rodrigo Muino Tomonari requested to merge github/fork/richardlau/v18.x-revert-libuv into v18.x-staging

Temporarily revert recent libuv updates (1.46.0 and 1.45.0) in Node.js 18 to fix regressions:

Also https://github.com/nodejs/node/issues/49911 which is a separate bug that was exposed by the performance profile change that IO_URING introduced (for this particular one I've already landed the Node.js fix on the staging branch but it demonstrates the risk that drastic performance changes can have on LTS release lines).

While the IO_URING issues can be worked around by setting UV_USE_IO_URING=0 in the environment, the Windows FS regression cannot. Upstream libuv contains fixes for the Windows regression and IO_URING fixes that are not yet in a libuv release:

I think it's too early to have IO_URING enabled by default in LTS Node.js. Were it just the IO_URING issues I might propose patching libuv to disable it by default in Node.js 18 instead of reverting the updates.

Even if a new libuv version was to be made available now we normally would not land that in LTS until it has been released in a current release for two weeks.

cc @nodejs/lts @nodejs/releasers

Merge request reports