Skip to content

test: v8: Add test-linux-perf-logger test suite

Rodrigo Muino Tomonari requested to merge github/fork/lukealbao/add-v8-perf-fn-only-test into main

This patch adds test coverage for the --perf-prof-basic* v8 flags.

This ports the repro from #50225 (closed), which is fixed in main as of https://github.com/nodejs/node/commit/f6f681b62a0eb5cd9b162b545ba5d91cb8bf1379.

Relatedly, but out of scope here: I believe this also enables removal of the flaky perf(1) integration tests reported in #50079. Those tests missed the bug reported in #50225 (closed). They also don't strictly need to integrate with perf, as far as I can tell. The integration point (the perf map file) is done out-of-band from the perf recording; it is enabled via the v8 flags. See dso__load_perf_map for details on how it is consumed.

Merge request reports