Skip to content

src: make ModifyCodeGenerationFromStrings more robust

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/modify-callback into main
  1. Fallback to true when the context is not (yet) initialized with the kAllowCodeGenerationFromStrings field.
  2. Fallback to true when the Environment isn't assigned to the context or when the Environment cannot call into JavaScript.

Refs: https://github.com/nodejs/node/issues/50761

I don't think this PR could actually fix the referenced issue but the guards should've been added anyway.

Merge request reports