Skip to content

node: improve nextTick performance

Rodrigo Muino Tomonari requested to merge github/fork/BridgeAR/master into master
  1. The try final block around the nextTick callback prevents optimizing the executing function. The try was introduced in a commit that was reverted later but without reverting the try code.
  2. Initializing the array with the proper argument size is faster as using a literal.

The performance gain is between 5-10% looking at the already existing nextTick benchmarks.

@trevnorris pointed out that this is might be depending on https://github.com/nodejs/node/pull/4507. I guess this could be handled independently though.

@bnoordhuis the new v8::Private api seems to change the error handling in C and after that commit the nextTick callback errors are not handled in C anymore. I'm not sure this was a intended change?

Merge request reports