Skip to content

src: enter isolate before destructing IsolateData

Rodrigo Muino Tomonari requested to merge github/fork/bnoordhuis/fix51129 into main

MVP fix for a worker_threads crash where ~WorkerThreadData() -> ~IsolateData() -> Isolate::DetachCppHeap() kicks off a round of garbage collection that expects an entered isolate.

No test because the crash is not reliably reproducable but the bug is pretty clearly described in the linked issue and is obvious once you see it, IMO.

Fixes: https://github.com/nodejs/node/issues/51129

Merge request reports

Loading