Skip to content

test: fix inconsistency write size in `test-fs-readfile-tostring-fail`

Rodrigo Muino Tomonari requested to merge github/fork/pluris/fix/test_fs_readfile into main

In this test, more space is being used than the space being checked. It's actually using more capacity in stream.write() than is written to kStringMaxLength. There are 201 buffers used in the for loop.

Even if this code is fixed, I'm not sure if the unstable tests are resolved. https://github.com/nodejs/node/blob/1b60054fffc0c67a711cdf3efbcc8f44afab0ce2/test/pummel/test-fs-readfile-tostring-fail.js#L18-L20 https://github.com/nodejs/node/blob/1b60054fffc0c67a711cdf3efbcc8f44afab0ce2/test/pummel/test-fs-readfile-tostring-fail.js#L29-L36

Refs: #51133 (closed)

Merge request reports