Skip to content

benchmark: update iterations of benchmark/assert/deepequal-buffer.js

Fixes: https://github.com/nodejs/node/issues/50571

Before applying this PR, the top functions are reading test JS file, instead of real logic code of "equal". After increasing the iteration value, the test case behaved as expected to trigger equal.

Belowing is the benefit after changing the iterations which can reflect real performance and no much overhead for execution time.

<!--table {mso-displayed-decimal-separator:"\."; mso-displayed-thousand-separator:"\,";} @page {margin:.75in .7in .75in .7in; mso-header-margin:.3in; mso-footer-margin:.3in;} tr {mso-height-source:auto;} col {mso-width-source:auto;} br {mso-data-placement:same-cell;} td {padding-top:1px; padding-right:1px; padding-left:1px; mso-ignore:padding; color:black; font-size:11.0pt; font-weight:400; font-style:normal; text-decoration:none; font-family:Calibri, sans-serif; mso-font-charset:0; mso-number-format:General; text-align:general; vertical-align:bottom; border:none; mso-background-source:auto; mso-pattern:auto; mso-protection:locked visible; white-space:nowrap; mso-rotate:0;} .xl65 {mso-number-format:0%;} -->
        before PR after PR benefit
assert/deepequal-buffer.js method="deepEqual" arrayBuffer=0 strict=0 1102178.19 811018.53 136%
assert/deepequal-buffer.js method="deepEqual" arrayBuffer=1 strict=0 2126510.614 1449499.9 147%
assert/deepequal-buffer.js method="deepEqual" arrayBuffer=0 strict=1 1076920.796 824504.47 131%
assert/deepequal-buffer.js method="notDeepEqual" arrayBuffer=0 strict=1 1501014.19 1083974.3 138%
assert/deepequal-buffer.js method="unequal_length" arrayBuffer=0 strict=1 2474651.786 1541873.8 160%
assert/deepequal-buffer.js method="deepEqual" arrayBuffer=1 strict=1 1451921.906 1044787.8 139%
assert/deepequal-buffer.js method="notDeepEqual" arrayBuffer=1 strict=1 2085341.463 1421480 147%
assert/deepequal-buffer.js method="unequal_length" arrayBuffer=1 strict=1 2894782.473 1801186.3 161%
assert/deepequal-buffer.js method="deepEqual" arrayBuffer=0 strict=0 1073006.858 804104.05 133%
assert/deepequal-buffer.js method="deepEqual" arrayBuffer=1 strict=0 2067498.834 1391137.1 149%
assert/deepequal-buffer.js method="deepEqual" arrayBuffer=0 strict=1 1068874.391 809949.48 132%
assert/deepequal-buffer.js method="notDeepEqual" arrayBuffer=0 strict=1 1495734.765 1071242.3 140%
assert/deepequal-buffer.js method="unequal_length" arrayBuffer=0 strict=1 2474115.678 1539677.9 161%
assert/deepequal-buffer.js method="deepEqual" arrayBuffer=1 strict=1 1419495.005 1047928.8 135%
assert/deepequal-buffer.js method="notDeepEqual" arrayBuffer=1 strict=1 2054114.939 1394304.8 147%
assert/deepequal-buffer.js method="unequal_length" arrayBuffer=1 strict=1 2905970.911 1776728 164%

Merge request reports

Loading