Skip to content

Ensure there's a channel before trying to send on it

Rodrigo Muino Tomonari requested to merge github/fork/arlolra/err into master

Here's a trace on v0.12.9,

AssertionError: null == true
    at process.target._send (child_process.js:420:5)
    at process.<anonymous> (child_process.js:396:12)
    at process.emit (events.js:129:20)
    at handleMessage (child_process.js:324:10)
    at Pipe.channel.onread (child_process.js:350:11)

_disconnect nulls out the channel, but admits there may still be some buffering. If that's a NODE_HANDLE message, it'll attempt this ack. handleMessage has a similar check.

cc/ @inez

Merge request reports