Skip to content

Revert "fs: deprecate fs.read's string interface"

Rodrigo Muino Tomonari requested to merge github/fork/MylesBorins/revert-1124de2 into master

This reverts commit 1124de2d which landed in https://github.com/nodejs/node/pull/4525

This commit has broken both npm + node-gyp

How did it break npm?

Deprecating fs.read's string interface includes internal/util Currently npm's dep tree includes an old version of graceful-fs that is monkey patching fs. As such everything explodes when trying to require internal/util

https://github.com/nodejs/node/pull/5102 is waiting for review but has not landed. We should revert ASAP to fix master while we decide what to do.

/cc @nodejs/collaborators @rvagg @jasnell

Merge request reports