Skip to content

(vee-eight-4.9) Replace more deprecated V8 API usage

Rodrigo Muino Tomonari requested to merge github/fork/ofrobots/vee-eight-4.9 into vee-eight-4.9

Continuing from https://github.com/nodejs/node/pull/5159, this PR replaces deprecated uses of SetAccessor and most uses of SetWeak on the vee-eight-4.9 branch.

The use of SetWeak in src/node_buffer.cc is more involved because it expects to get a handle to the weak object in the weak callback. I need to understand the buffer code a bit more before attempting to change that.

EDIT: the original change for SetWeak usage in node_contextify was flawed. I have removed that.

Remaining work:

  • SetWeak – src/node_contextify.cc: #5392
  • SetWeak – src/node_buffer.cc
  • NewExternal — src/string_bytes.cc

See also: https://github.com/nodejs/node/issues/4869 R=@bnoordhuis , @targos /cc @nodejs/v8

Merge request reports