Skip to content

lib: pass through net.Server options during IPC

Rodrigo Muino Tomonari requested to merge github/fork/cjinhuo/pass_through_net_server_config_during_ipc into main

I send net.Server instance with any options,but finally get a whole new net.Server instance in child process.For example, I create a new net.Server instance with {allowHalfOpen: true},then will get a new net.Server instance with {allowHalfOpen: false} in child process.The example is as follows.

const assert = require('assert')
const net = require('net');
const child_process = require('child_process');

if (process.argv[2] !== 'child') {
  const childProcess = child_process.fork(__filename, ['child']);
  const server = net.createServer({
    allowHalfOpen: true
  })
  server.listen(9999, () => {
    childProcess.send(null, server)
  })
} else {
  process.on('message', (msg, handle) => {
    // the handle.allowHalfOpen will be false,indicates that the attribute of the server instance sent from the parent process has been modified
    assert.ok(handle.allowHalfOpen, true) // will throw AssertionError
  });
}

In my view, if the net.Server be configured some options, they should be passed on completely. Is that right?

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports