Skip to content

test: fix Windows native test suites

4 days ago, 2 PRs that landed independently around the same time caused this issue causing every native test suite run in CI to fail on Windows. This is just a quick patch to unblock the CI.

One PR added running test\embedding\test-embedding.js on Windows, and the other one added a new test case in the same file. As it turned out, that case is failing on Windows. This is a simple fix to reenable CI as without it no PRs can be merged and a follow-on PR actually fixing this issue is welcome.

I've already run my branch against the CI to make sure native suites are fixed and they are: https://ci.nodejs.org/job/node-test-commit-windows-fanned/63233/

Tagging @RafaelGSS and @vmoroz as they opened the 2 PRs in question

Refs: https://github.com/nodejs/node/pull/52905 Refs: https://github.com/nodejs/node/pull/52646

Merge request reports

Loading