Skip to content

module: allow module.register from workers

Rodrigo Muino Tomonari requested to merge github/fork/dygabo/allow-hooks-thread-from-worker into main

this is a fix for #53182 (closed)

by implementing a guard on the native side, we can ensure that the internal customization hooks thread is instantiated only once but not necessarily from the main thread. https://github.com/ShogunPanda/hooks-repro example is not hanginng

the second commit reenables the tests that were skipped because module.register() was temporarily not supported on worker threads.

One is still failing on workers. Currently analyzing.

This implements the fix based on solution number 2. from this comment

alternative to #53183

Merge request reports