Skip to content

fs: optimize `fs.cpSync` js calls

Rodrigo Muino Tomonari requested to merge github/fork/anonrig/optimize-cp-sync into main

https://github.com/nodejs/node/pull/53612 is required to do a benchmark

A different approach to https://github.com/nodejs/node/pull/53541

cc @nodejs/performance @nodejs/cpp-reviewers @billywhizz @jasnell @nodejs/fs

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1573/

Small win on happy path, and probably high win on error path:

                           confidence improvement accuracy (*)   (**)   (***)
fs/bench-cpSync.js n=1            ***     21.96 %       ±6.85% ±9.14% ±11.97%
fs/bench-cpSync.js n=100          ***     14.91 %       ±2.86% ±3.81%  ±4.97%
fs/bench-cpSync.js n=10000        ***      9.74 %       ±1.28% ±1.71%  ±2.23%

Merge request reports