Skip to content

tests: remove legacy regression test -> double pipe

Rodrigo Muino Tomonari requested to merge github/fork/eljefedelrodeodeljefe/deprecate-pipe-double into master

Description of change

as described at #5373 (closed)

This test was introduced in 07da49b0 and seems to be obsolete since 96e423a6, when child_process was deprecated from c++ land.

Motivation to change this is, that it requires sed and grep on windows, yet being the only occurences of those. I decided to propose deletion, since it's difficult to reproduce the breaking case in the current node implementation.

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Affected core subsystem(s)

child_process

Merge request reports