(vee-eight-4.9) contextify: update deprecated SetWeak usage (!5392) · Merge requests · Rodrigo Test / Test Group-nodejs / node · GitLab

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Rodrigo Muino Tomonari requested to merge github/fork/ofrobots/setweak-contextify into vee-eight-4.9 Feb 23, 2016

Description of change

Follow on from #5204 (which is pending landing once the CI resumes).

This PR cleans up the complexity with how weakness was being used in node_contextify and updates to the new style Phantom weakness API.

Pull Request check-list

Please make sure to review and check all of these items:

Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
Is the commit message formatted according to CONTRIBUTING.md?
If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?
Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Affected core subsystem(s)

contextify

R=@bnoordhuis, @indutny /cc @nodejs/v8