Skip to content

dgram: handle default address case when offset and length are specified

Rodrigo Muino Tomonari requested to merge github/fork/mcollina/fix-dgram-regression into master

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Affected core subsystem(s)

dgram

Description of change

Fixes a regression introduced by https://github.com/nodejs/node/pull/4374 and released in 5.7.0. Adds a new test to avoid similar issue in the future.

Fixes: https://github.com/nodejs/node/issues/5398

Please review @jasnell @saghul @mafintosh @Fishrock123 @rvagg

Merge request reports