Skip to content

src: remove cached data tag from snapshot metadata

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/remove-flag into main

This only served as a preemptive check, but serializing this in the snapshot would make it unreproducible on different hardware. In the current cached data version tag, the V8 version can already be checked as part of the existing Node.js version check. The V8 flags aren't necessarily important for snapshot/code cache mismatches (only a small subset are), and the CPU features currently don't matter, so doing an exact match is stricter than necessary. Removing the check to help making the snapshot more reproducible on different hardware.

Refs: https://github.com/nodejs/build/issues/3043

Merge request reports

Loading