Skip to content

dns: exclude loopback link from the single lookup resolution

Rodrigo Muino Tomonari requested to merge github/fork/puskin94/dns-single-lookup-exclude-loopback into main

dns: the lookup of a single address should not be returned if the result is a loopback link

Fixes: https://github.com/nodejs/node/issues/51732

As described in the original issue, I am having problems writing working automated tests:

if /etc/hosts is modified to have this entry fe80::1 ipv6_loopback tests are working just fine, but of course it is not a valid solution. I tried to mock the inner workings of the actual dns resolved but I was not able to make it work fine for my test case.

two questions:

  1. does anybody know how to fix the "broken" test?
  2. are the new API (the returned values) fine?

Merge request reports