Skip to content

deps: backport ICU-22787 to fix ClangCL on Windows

Rodrigo Muino Tomonari requested to merge github/fork/JaneaSystems/mefi-icu-2 into main

This is a change I landed in the ICU at https://github.com/unicode-org/icu/pull/3023. It is needed to enable ClangCL compilation for Node.js on Windows and that's why I'm porting it manually now before the next ICU update. After this PR lands, I'll open a follow-up one changing the icu-generic.gyp to take advantage of the ICU changes.

This PR aims to do the same thing as https://github.com/nodejs/node/pull/54448, but in the correct way.

NOTE: Since this is a patch to be made unnecessary by the next ICU release, I fixed issues with #include ... in patch files by copying .h files to the directories that need them (where .c files that include them are), rather than fixing everything cleanly, as that would require bigger changes in configure.py for a feature that was last used in 2019.

cc @richardlau

Merge request reports