Skip to content

path: fix win32 relative() when "to" is a prefix

Rodrigo Muino Tomonari requested to merge github/fork/omsmith/path-win32-fix-relative into master

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
    • make -j8 test
    • vcbuild test nosign
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Affected core subsystem(s)

  • path

Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)

Description of change

Please provide a description of the change here.

when the basename of "to" was a prefix of the basename of "from" win32 relative() would miss including it in the result

Fixes #5447 (closed)

R=@mscdex

Merge request reports