Skip to content

test: update TLS test for OpenSSL 3.2

Rodrigo Muino Tomonari requested to merge github/fork/richardlau/openssl32tests into main

Update parallel/test-tls-set-sigalgs to account for error code changes in OpenSSL 3.2 and later.

Refs: https://github.com/nodejs/node/issues/53382#issuecomment-2315637142 Refs: https://github.com/nodejs/node/pull/53384

cc @nodejs/crypto

Addresses this failure with OpenSSL 3.2:

14:45:03 not ok 2996 parallel/test-tls-set-sigalgs
14:45:03   ---
14:45:03   duration_ms: 366.47000
14:45:03   severity: fail
14:45:03   exitcode: 1
14:45:03   stack: |-
14:45:03     (node:2717679) [DEP0060] DeprecationWarning: The `util._extend` API is deprecated. Please use Object.assign() instead.
14:45:03     (Use `node --trace-deprecation ...` to show where the warning was created)
14:45:03     node:assert:126
14:45:03       throw new AssertionError(obj);
14:45:03       ^
14:45:03     
14:45:03     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
14:45:03     + actual - expected
14:45:03     
14:45:03     + 'ERR_SSL_SSL/TLS_ALERT_HANDSHAKE_FAILURE'
14:45:03     - 'ERR_SSL_SSLV3_ALERT_HANDSHAKE_FAILURE'
14:45:03         at /home/iojs/build/workspace/richardlau-node-test-commit-linux-containered/test/parallel/test-tls-set-sigalgs.js:51:16
14:45:03         at /home/iojs/build/workspace/richardlau-node-test-commit-linux-containered/test/common/index.js:488:15
14:45:03         at /home/iojs/build/workspace/richardlau-node-test-commit-linux-containered/test/common/index.js:488:15
14:45:03         at maybeCallback (/home/iojs/build/workspace/richardlau-node-test-commit-linux-containered/test/fixtures/tls-connect.js:97:7)
14:45:03         at TLSSocket.<anonymous> (/home/iojs/build/workspace/richardlau-node-test-commit-linux-containered/test/fixtures/tls-connect.js:73:13)
14:45:03         at TLSSocket.emit (node:events:520:28)
14:45:03         at emitErrorNT (node:internal/streams/destroy:170:8)
14:45:03         at emitErrorCloseNT (node:internal/streams/destroy:129:3)
14:45:03         at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
14:45:03       generatedMessage: true,
14:45:03       code: 'ERR_ASSERTION',
14:45:03       actual: 'ERR_SSL_SSL/TLS_ALERT_HANDSHAKE_FAILURE',
14:45:03       expected: 'ERR_SSL_SSLV3_ALERT_HANDSHAKE_FAILURE',
14:45:03       operator: 'strictEqual'
14:45:03     }
14:45:03     
14:45:03     Node.js v23.0.0-pre
14:45:03   ...

https://ci.nodejs.org/job/richardlau-node-test-commit-linux-containered/32/nodes=ubuntu2204_sharedlibs_openssl32_x64/console

Merge request reports