Skip to content

(vee-eight-4.9) src: update uses of deprecated NewExternal

Rodrigo Muino Tomonari requested to merge github/fork/ofrobots/newexternal into vee-eight-4.9

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Affected core subsystem(s)

src (string_bytes)

Description of change

V8 String::NewExternal is deprecated in 4.9. Migrate string_bytes.cc to the alternatives.

R=@bnoordhuis @nodejs/v8 Ref: #5392, #5204, #4869 (closed)

Merge request reports