Skip to content

net: make `isIPv4` and `isIPv6` more efficient

Rodrigo Muino Tomonari requested to merge github/fork/vkurchatkin/isipv-4-6 into master

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Affected core subsystem(s)

net

Description of change

isIPv4 and isIPv6 are implemented on top of isIP, which in turn checks the sting for being both IPv4 and IPv6, which can be inefficient in some scenarios. This commit makes them use uv_inet_pton directly instead.

Merge request reports