Skip to content

updates crypto.markdown to use good default settings

Rodrigo Muino Tomonari requested to merge github/fork/billautomata/patch-1 into master

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Affected core subsystem(s)

Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)

  • Crypto docs

Description of change

Please provide a description of the change here.

createDiffieHellman(11) asks people to create 11 bit keys, which is laughable. I could crack it by hand. A very smart person could crack it in their heads, in less than five minutes.

We should be advising nodejs users to pass a group by name, like we do with the ECDH example. modp14 is suitable strength while maintaining good performance.

This is the reference for the diffiehellman modp group.

Merge request reports