Skip to content

tools: improve js linter

Rodrigo Muino Tomonari requested to merge github/fork/mscdex/tools-improve-linter into master

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Affected core subsystem(s)

  • tools

Description of change

This commit switches from the eslint command-line tool to a custom tool that uses eslint programmatically in order to perform linting in parallel and to display linting results incrementally instead of buffering them until the end. There is also now a progress indicator similar to that of make test.

Additionally, there is a new lint-ci rule that disables the progress indicator. I guess the command used on the linter Jenkins node will need to be changed internally as I couldn't find where it's configured to use what command.

Fixes: https://github.com/nodejs/node/issues/5596

Merge request reports