Skip to content

test: refactor http-end-throw-socket-handling

Rodrigo Muino Tomonari requested to merge github/fork/santigimeno/http-end-throw into master

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Affected core subsystem(s)

test

Description of change

Remove timer to avoid the test to timeout occasionally.

I have been getting this error on OS X:

=== release test-http-end-throw-socket-handling ===                            
Path: parallel/test-http-end-throw-socket-handling
/Users/sgimeno/node/node/test/parallel/test-http-end-throw-socket-handling.js:35
  throw new Error('Taking too long!');
  ^

Error: Taking too long!
    at ._onTimeout (/Users/sgimeno/node/node/test/parallel/test-http-end-throw-socket-handling.js:35:9)
    at Timer.unrefdHandle (timers.js:454:14)
Command: out/Release/node /Users/sgimeno/node/node/test/parallel/test-http-end-throw-socket-handling.js

Merge request reports