Skip to content

test: remove the use of curl in the test suite

Rodrigo Muino Tomonari requested to merge github/fork/santigimeno/remove_curl into master

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Affected core subsystem(s)

test

Description of change

There were 2 tests using curl:

test-http-304.js is removed because it was initially included to test that the 304 response does not contain a body, and this is already covered by test-http-chunked-304.js.

test-http-curl-chunk-problem has been refactored so instead of using curl, it uses 2 child node processes: one for sending the HTTP request and the other to calculate the sha1sum. Originally, this test was introduced to fix a bug in nodejs@0.2.x, and it was not fixed until nodejs@0.2.5. A modified version of this test has been run with nodejs@0.2.0 and reproduces the problem. This same test has been run with nodejs@0.2.6 and runs correctly.

Merge request reports