Skip to content

tls: deprecate `newSession`/`resumeSession` events

Rodrigo Muino Tomonari requested to merge github/fork/indutny/fix/gh-1462 into master

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Affected core subsystem(s)

tls

Description of change

Deprecate asynchronous newSession/resumeSession events, introduce a synchronous APIs via newSession/resumeSession option-callback for tls.createServer.

The reason for this transition is rather simple. There is a quite big amount of code that was added to support this construction, and not that much users of it. Additionally, that code chunk is running in front of OpenSSL, so it makes the process of asynchronous session resumption twice as ineffective.

See: #1462 (closed)

Merge request reports