Skip to content

events: make eventNames() return only enumerable properties

Rodrigo Muino Tomonari requested to merge github/fork/lpinca/enumerable-symbol-properties into master

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Affected core subsystem(s)

events

Description of change

Right now eventNames() returns all the symbol properties (enumerable or not) directly found in _events. This patch prevents non-enumerable symbol properties from being included in the returned array.

Merge request reports