Skip to content

dns: Use object without protoype for map

Rodrigo Muino Tomonari requested to merge github/fork/benjamingr/dns-refactor-object-map-to-createnull into master

Pull Request check-list

Affected core subsystem(s)

dns

Description of change

Please provide a description of the change here.

Currently we use {} for the lookup function to find the relevant resolver to the dns.resolve function. It is preferable to use an object without a Object.prototype, currently for example you can do something like:

dns.resolve("google.com", "toString", console.log);

And get [Object undefined] logged and the callback would never be called. This is unexpected and strange behavior in my opinion. In addition, if someone adds a property to Object.prototype might also create unexpected results.

I recalled a client actually ran into this issue in production a while ago so now that I'm touching a bunch of dns I figured I might as well fix it :)

This pull request fixes it, with it an appropriate error is thrown.

I tagged this semver-major to be on the safe side since an error is thrown where strange behavior currently happens. This is more likely a bug fix but I figured I'd error on the safe side - this is more like a bug fix.

Please advise.

Merge request reports