Skip to content

buffer: add Buffer compare by offset

Rodrigo Muino Tomonari requested to merge github/fork/jasnell/buffer-compare-offset into master

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Affected core subsystem(s)

buffer

Description of change

Adds additional offset, length and thisOffset arguments to Buffer.prototype.compare to allow comparison of sub-ranges of two Buffers without requiring Buffer.prototype.slice()

Fixes: https://github.com/nodejs/node/issues/521 /cc @trevnorris @rootslab @jorangreef

Merge request reports