Skip to content

lib: remove Object from global's prototype

Rodrigo Muino Tomonari requested to merge github/fork/bmeck/non-Object-global into master

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?

Affected core subsystem(s)

lib

Description of change

Removes some strange behavior from having Object in the global object's prototype chain. No longer introducing global variables coming from Object.prototype.

These globals have strange warts from existing but we should throw this in CITGM this to see if anything is affected. The only thing I really am suspicious of is toString might be used by some people via type coercion like var_that_refs_global+''.

This would be a breaking change.

Merge request reports