Skip to content

configure: introduce --embedded

Rodrigo Muino Tomonari requested to merge github/fork/indutny/feature/atom-2 into master

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Affected core subsystem(s)

node

Description of change

Add configure flag for building shared library that could be used to embed node.js in some application (like Electron). This commit is esentially a merged and refined version of:

  • atom/node@289649a919d557182ff951589fc9859778206e4c
  • atom/node@f76669ffdcb8613133dc9c3764fb21c10207582e
  • atom/node@0828dfa193038209b7b337ba5479c3373f7cf87f

Merge request reports