Skip to content

build: enable compilation for linuxOne

Rodrigo Muino Tomonari requested to merge github/fork/mhdawson/linuxone into master

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Affected core subsystem(s)

build

Description of change

Changes to Node core in order to allow compilation for linuxOne.

The ../archs/linux32-s390x/opensslconf.h and ../archs/linux64-s390x/opensslconf.h were automatically generated by running make linux-ppc linux-ppc64 in the deps/openssl/config directory as per our standard practice

After these changes we still need a version of v8 which supports linuxOne but that will be coming soon in the 5.1 version of v8.

I tested by building a version of node.js from master with the latest v8 tree based on the vee-eight-lkgr branch of https://github.com/ofrobots/node and then adding both this patch and additional patches to v8 for linuxOne. The additional patches for v8 were required because since it was based off of lkgr there is no guarantee you get a tree that compiles for all platforms at any given point in time.

The net is that it compiled but there are test failures, many due to networking. I think those are not related to anything needed in this patch. We we don't see these failures in our internal environments and I also saw a number of failures in the libuv tests which makes me think its something to do with the machine setup (one of my next things to look into). This is the test job: https://ci.nodejs.org/job/node-test-commit-linuxone-mdawson/14/nodes=rhel72-s390x/consoleFull

Getting these changes in now will make it easier to be ready when we get v8 5.1 and to start investigating the issues seen so far.

Merge request reports