Skip to content

src: Add missing `using v8::MaybeLocal` (v5.x)

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/fix-using-maybelocal-on-5.x into v5.x

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?

Affected core subsystem(s)

src

Description of change

As of 2cbbaafc (#5756) there’s a missing using v8::MaybeLocal; in src/node.cc that breaks the build. This patch adds the necessary line.

I guess this slipped through because the corresponding line is present in master?

This test is failing btw.

/cc @evanlucas @trevnorris

Merge request reports