Skip to content

Fix make tar-headers for Linux

Rodrigo Muino Tomonari requested to merge github/fork/gibfahn/headers-fix into master

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Affected core subsystem(s)

build

Description of change

The make tar-headers target currently fails on Linux due to the command find $(TARNAME)/ -type l | xargs rm as the find is unable to find any links, so the rm fails with a no arguments error. The simplest solution is to simply remove this line (assuming we aren't expecting an links). If anyone thinks they can still appear, then I can do something like:

if [ `find $(TARNAME)/ -type l` ]; then
  find $(TARNAME)/ -type l | xargs rm
fi

I also removed the dependency on config.gypi, as the tar-headers target runs configure itself.

Related Issue: #4149 (see this comment)

Merge request reports