url: fix format when query is not an object (!6005) · Merge requests · Rodrigo Test / Test Group-nodejs / node · GitLab

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Rodrigo Muino Tomonari requested to merge github/fork/ajafff/url-format-query into master Apr 01, 2016

Pull Request check-list

Please make sure to review and check all of these items:

Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
Is the commit message formatted according to CONTRIBUTING.md?
If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?
Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Affected core subsystem(s)

url

Description of change

url.format uses query if search is falsy. Currently query is only used if it is an object. Query will now be inserted if its value is truthy.

Fixes: #6004 (closed)