Skip to content

test: fix flakiness of stringbytes-external

Rodrigo Muino Tomonari requested to merge github/fork/ofrobots/stringbytes-external into master

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?

Affected core subsystem(s)

test

Description of change

The tests used to rely on precise timing of when a JavaScript object would be garbage collected to ensure that there is enough memory available on the system. Switch the test to use a malloc/free pair instead.

Ref: https://github.com/nodejs/node/pull/5945 R=@bnoordhuis, @trott CI: https://ci.nodejs.org/job/node-test-pull-request/2146/ CI: https://ci.nodejs.org/job/node-test-pull-request/2147/ CI: https://ci.nodejs.org/job/node-test-pull-request/2148/

Merge request reports