Skip to content

querystring: don't inherit from Object.prototype

Rodrigo Muino Tomonari requested to merge github/fork/mscdex/querystring-parse-empty-prototype into master

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included?

Affected core subsystem(s)

  • querystring

Description of change

This commit safely allows querystring keys that are named the same as properties that are ordinarily inherited from Object.prototype such as proto. Additionally, this commit provides a bit of a speed improvement (~25% in the querystring-parse 'manypairs' benchmark) when there are many unique keys.

Fixes: https://github.com/nodejs/node/issues/5642

Merge request reports