Skip to content

deps: Intl: ICU 57 bump

Rodrigo Muino Tomonari requested to merge github/fork/srl295/icu4c-57 into master

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included? ( No )
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? ( n/a )

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Affected core subsystem(s)

Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)

Description of change

Please provide a description of the change here.

  • bump to ICU 57.1 - update URL / hash
  • add exclusion list for 57 (sorry, missed 56). This will reduce the binary footprint on some platforms.
  • Exclude cstr.cpp to work around http://bugs.icu-project.org/trac/ticket/12451 on Windows/MSVC

Fixes: https://github.com/nodejs/node/issues/6058

Merge request reports