Skip to content

buffer: standardize array index check

Rodrigo Muino Tomonari requested to merge github/fork/trevnorris/fix-parseindex into master

Checklist

  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

buffer

Description of change

ParseArrayIndex() was requesting a Uint32Value(), but assigning it to an in32_t. This caused slight differences in error message reported in edge cases of argument parsing. Fixed by getting the IntegerValue() before checking if the value is < 0. Added test of API that was affected.

R=@bnoordhuis R=@jasnell

CI: https://ci.nodejs.org/job/node-test-pull-request/2179/

Merge request reports