Skip to content

repl: refactor `LineParser` implementation

Rodrigo Muino Tomonari requested to merge github/fork/blakeembrey/repl-custom-eval into master
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • repl
Description of change

Move the core logic from LineParser should fail handling into the recoverable error check for the REPL default eval. This was originally from https://github.com/nodejs/node/pull/3488, and I've split it out for separate review and hopefully speed it up. The idea is to make the current recoverable check part of the default eval instead of limiting the usefulness of the REPL functionality to only JavaScript languages (E.g. enable TypeScript).

Merge request reports