Skip to content

handle_wrap: IsRefed -> Unrefed, no isAlive check

Rodrigo Muino Tomonari requested to merge github/fork/Fishrock123/better-handle-refed-check into master
Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

handle_wrap

Description of change

This fixes my perceived usability issues with https://github.com/nodejs/node/pull/5834, which has not landed in any release except v6 RCs. This should not be considered a breaking change due to that.

It is useful if you have a handle, even if it has been closed, to be able to inspect whether that handle was unrefed or not. As such, I have renamed the method accordingly. If people need to check a handle's aliveness, that is a separate API we should consider exposing.

cc @trevnorris, @jasnell, @cjihrig

Merge request reports