Skip to content

deps: cherry-pick 1ef7487b from v8 upstream

Rodrigo Muino Tomonari requested to merge github/fork/mhdawson/ras into master
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

deps/v8

Description of change

Original commit message:

We'd like this in 6.x to help with diagnosing customer problems. It provides a better message on OOM so that it is easier to be able to tell whether the OOM was due to heap exhaustion or running out of native memory. Is already landed in google master.

 Improved diagnostic message for JS heap out of memory

 This patch replaces the unused 'take_snapshot' parameter on
 FatalProcessOutOfMemory() with a 'is_heap_oom' parameter.
 The parameter is set to true on error paths where the
 JS heap is out of memory, as distinct from a malloc()
 failure i.e. process out of memory.  The message output to
 stderr or passed to embedding applications via FatalErrorCallback
 is 'Javascript heap out of memory' rather than
 'process out of memory'.

 BUG=

 R=jochen@chromium.org, verwaest@chromium.org, michael_dawson@ca.ibm.com

 Review URL: https://codereview.chromium.org/1873443002

 Cr-Commit-Position: refs/heads/master@{#35431}

Merge request reports