Skip to content

build: make addon testing part of `make test`

Rodrigo Muino Tomonari requested to merge github/fork/bnoordhuis/test-addons-more into master
Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

build: make addon testing part of make test

Otherwise it's too easy to miss breaking changes to node.h and other public headers until the CI catches them. vcbuild test tests addons so there is precedence.

( test: is perhaps a better prefix but most commits to Makefile prefix with build. I follow slavishly.)

CI: https://ci.nodejs.org/job/node-test-pull-request/2284/

Merge request reports