Skip to content

v8: warn in Template::Set() on improper use

Rodrigo Muino Tomonari requested to merge github/fork/bnoordhuis/template-set-warning into master

The next major release will make it a fatal error to use non-primitive values in function templates and object templates.

Print a warning that includes the C and JS stack trace to tell people to upgrade their add-ons. The C stack trace is only printed on platforms that support it (the BSDs, OS X and Linux+glibc.)

Refs: #6216 (closed)

Speculative - I'd like some input whether other collaborators think it's a good approach. It can get pretty noisy when native code abuses v8::Template::Set() a lot but OTOH, hopefully that means it gets fixed quickly.

CI: https://ci.nodejs.org/job/node-test-pull-request/2319/

Merge request reports