Skip to content

Revert "handle_wrap: IsRefed -> Unrefed, no isAlive check"

Rodrigo Muino Tomonari requested to merge github/fork/Fishrock123/revert-9bb5a5e into master
Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

handle_wrap

Description of change

This reverts commit 9bb5a5e2.

Refs: https://github.com/nodejs/node/pull/6395 Refs: https://github.com/nodejs/node/pull/6204 Refs: https://github.com/nodejs/node/pull/6401 Refs: https://github.com/nodejs/node/pull/6382 Fixes: https://github.com/nodejs/node/pull/6381

Conflicts: src/handle_wrap.cc test/parallel/test-handle-wrap-isrefed-tty.js test/parallel/test-handle-wrap-isrefed.js

My own stupidity for changing this. cc @bnoordhuis, @jasnell, @trevnorris so this can hopefully be landed properly into a release. (Hopefully this week?..)

Merge request reports