Skip to content

src,lib: minor --debug-brk cleanup

Rodrigo Muino Tomonari requested to merge github/fork/ofrobots/debug-wait-connect into master
Checklist
  • tests and code linting passes
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

src,lib

Description of change

Minor cleanup of how --debug-brk works:

  • We no longer need to use command line flags to expose the debug object.
  • Do not depend on the existence of global.v8debug as a mechanism to determine if --debug-brk was specified. We may overwrite the debug listener with the dummy listener when --expose-debug-as=v8debug was otherwise present on the command line.
  • We no longer need to set a dummy listener with --debug-brk.

This in anticipation of an upcoming PR with v8-inspector support.

R=@bnoordhuis /cc @eugeneo

Merge request reports