Skip to content

timers: use HandleWrap::Unrefed

Rodrigo Muino Tomonari requested to merge github/fork/Fishrock123/timers-use-handle-unrefed-check into master
Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

timers

Description of change

So, there a couple things going on here:

  • I originally wanted to do this, I don't like relying on a JS property much.
  • This breaks down if someone {un}refs the handle from C++, is that actually an issue?

CI: https://ci.nodejs.org/job/node-test-pull-request/2594/

Merge request reports